test(nebula_ros): add smoke tests #240
Open
+73
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 27.24% 27.00% -0.24%
==========================================
Files 104 104
Lines 9445 9251 -194
Branches 2324 2051 -273
==========================================
- Hits 2573 2498 -75
+ Misses 6436 6339 -97
+ Partials 436 414 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Max SCHMELLER <[email protected]>
Signed-off-by: Max SCHMELLER <[email protected]>
…_hw_interfaces too Signed-off-by: Max SCHMELLER <[email protected]>
Signed-off-by: Max SCHMELLER <[email protected]>
mojomex
force-pushed
the
test/launch-tests
branch
from
58c3d8d to
ad35b01
Compare
mojomex
added a commit
that referenced
this pull request
Feb 3, 2025
commit ad35b01 Author: Max SCHMELLER <[email protected]> Date: Mon Dec 2 16:28:51 2024 +0900 chore(cspell): add CMake's `TOLOWER` keyword to dictionary Signed-off-by: Max SCHMELLER <[email protected]> commit 6dee292 Author: Max SCHMELLER <[email protected]> Date: Wed Nov 27 21:54:11 2024 +0900 temp(nebula_tests): run nebula_tests on changes to nebula_ros, nebula_hw_interfaces too Signed-off-by: Max SCHMELLER <[email protected]> commit e981de2 Author: Max SCHMELLER <[email protected]> Date: Wed Nov 27 21:36:27 2024 +0900 temp: only Hesai smoke tests Signed-off-by: Max SCHMELLER <[email protected]> commit 40b6532 Author: Max SCHMELLER <[email protected]> Date: Wed Nov 27 21:20:03 2024 +0900 test(nebula_ros): add smoke test for every sensor Signed-off-by: Max SCHMELLER <[email protected]> Signed-off-by: Max SCHMELLER <[email protected]>
drwnz
approved these changes
Feb 4, 2025
| ament_lint_auto_find_test_dependencies() | ||
|
|
||
| foreach(MODEL Pandar40P Pandar64 PandarQT64 PandarQT128 Pandar128E4X PandarAT128 PandarXT32 PandarXT32M) |
There was a problem hiding this comment.
How about adding XT16 to the Hesai smoke tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Add smoke tests for all sensors: each smoke test launches Nebula with the sensor's default configuration and with
launch_hw:=false.These ensure (among other behaviors) that:
In a later PR,
launch_hw:=trueshould also be included, testing whether Nebula can be terminated when waiting for a connection.Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks